nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

No support for international numbers #2301

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

No support for international numbers

Clients may have a number that does not follow the specified format, e.g. +60 2345 6789

To Reproduce

add-client n/John Lee p/+60 2345 6789 e/john@gmail.com a/21 Road

Expected behaviour

Screenshot 2024-11-15 at 4.32.57 PM.png

Severity

Low Reference – cs2103 bug severity levels

Desktop


[original: nus-cs2103-AY2425S1/pe-interim#3138] [original labels: type.FeatureFlaw severity.Low]

Meowloid commented 6 days ago

Team's Response

Thank you for your feedback. However, this issue has been marked as Not In Scope for the following reasons:

Reasons for Not In Scope

  1. As stated in multiple sections of the User Guide, this application is specifically designed for workshops operating in Singapore. The current implementation ensures compliance with local standards and use cases.

Screenshot 2024-11-17 at 11.48.59 PM.png

  1. The lack of support for international numbers is not a defect but a deliberate design choice based on the application's intended use. Expanding support for international numbers would constitute an enhancement or a new feature, not a fix.

  2. Rectifying this issue would require introducing additional complexity to the phone number validation logic, which is less important than the work that has already been completed for this iteration. Addressing this would divert resources away from higher-priority tasks that align with the application's current scope and target audience.

  3. When users attempt to input an international phone number, the application gracefully rejects it with a clear error message: "Phone numbers should only contain numbers, and it should be between 3 and 15 digits long." This ensures that the software does not crash and provides feedback consistent with its documented limitations.

Hence for these reasons that align with the definition of NotInScope, we have chose to give it that tag.

Screenshot 2024-11-18 at 12.02.41 AM.png

Duplicate status (if any):

--