nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Multiple clients are not allowed to have the same car #2302

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

Multiple clients are not allowed to have the same car

Users could wish to store the contact information of two people who use the same car and bring the car in for servicing separately. An example of this is a husband and wife, or father and son. However, this is not possible with the current functionality.

To Reproduce

add-client n/Father p/81234567 e/ron@gmail.com a/address add-client n/Son p/98765432 e/don@gmail.com a/address add-car 1 vrn/SJH9514P vin/KMH45678901234567 make/Toyota model/Corolla add-car 2 vrn/SJH9514P vin/KMH45678901234567 make/Toyota model/Corolla

Expected behaviour

Screenshot 2024-11-15 at 4.41.27 PM.png

Severity

Medium Reference – cs2103 bug severity levels

Desktop


[original: nus-cs2103-AY2425S1/pe-interim#3139] [original labels: severity.Medium type.FeatureFlaw]

Meowloid commented 1 week ago

Team's Response

Reason for change in severity

1) It is rare for two different people to bring in the same vehicle separately on two different occasions, and in this rare event, the workshop can either edit the previous client's contact to the latest client or choose to document the actual owner of the vehicle, rather than all family members. The workshop might have also already removed the previous client's records by the time the vehicle returns for another servicing, as they would no longer have needed it. 2) It is impossible for two different people to bring in the same vehicle at the same time, physically possible but the workshop would reasonably only need one point of contact.

Hence it is unfair to say that occasional inconvenience is caused as the product works fine in most contexts, with the vehicle having only one main owner.

Reason for NotInScope

1) The vast majority of Vehicle : Owner relationships are 1 : 1. In the rare event where multiple people can bring the same vehicle to the workshop, there are logical workarounds where common sense of the user is applicable, hence rectifying it is less important than the work that has been done already. 2) Adding additional support for a many owners to one vehicle relationship for a 'better' implementation will take more effort than the current implementation, reducing the effort available to spend on other more important tasks. 3) When a user attempts to add an existing vehicle, the software fails gracefully, with an error message informing the user that the Car already exists in MATER, which was also the intended behaviour.

Duplicate status (if any):

--