search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Inconsistent error language in phone number parameter constraint #2333

Open nus-pe-bot opened 2 weeks ago

nus-pe-bot commented 2 weeks ago

While I understand that the app textbox can't fit the UG's constraint list, a very crucial detail is missing: that + are also allowed. This, along with other omissions like "no spaces between number", is very misleading, especially considering it wouldn't have taken that long to type that inside, and that the text wouldn't have taken up that much space.

I chose medium because +codes are very common, phone numbers are very common, and ability to add + is very useful for phone numbers, the ommission of which in the very app is highly questionable

image.png

image.png

Putting this as feature flaw as per course website. Additionally, this is WORSE than simply being of lesser specificity. The fact that it says "Only numbers" in the app box is not just less specific, it is contradictory. This severity is why I put it as medium.

image.png

[original: nus-cs2103-AY2425S1/pe-interim#3173] [original labels: severity.Medium type.FeatureFlaw]

jonushzw commented 2 weeks ago

Team's Response

Our team finds the first part and the second part below the error message screenshot to imply two different issues.

First part: Our application does not support + codes, when it fact it does. (Application behaviour)

Second part: The error message is not specific enough, which is completely different from the above.

We are a bit unclear of your overall issue but we choose to assign this as a duplicate to bug #1519 as the second part is similar.

Duplicate status (if any):

Duplicate of #1519