nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Issues are space sensitive. Hence are not unique #2347

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

Description test water and test water (2 space) are considered different issues

Steps to reproduce edit i/test water i/test water

Expected input rejected

Actual accepted

Screenshots

image.png


[original: nus-cs2103-AY2425S1/pe-interim#1038] [original labels: severity.Low type.FunctionalityBug]

Meowloid commented 1 week ago

Team's Response

Thank you for your feedback. After reviewing it, we have categorized the issue as Not In Scope for the following reasons:

Prioritisation and Effort Addressing this would involve a substantial overhaul of the issue field. Specifically, we would need to implement additional character-level validation of spaces logic to ensure that issues match precisely, accounting for various potential discrepancies. This would also require extensive modifications to the underlying data handling processes, including updates to how issues are stored, compared, and retrieved within the system. Furthermore, thorough testing would be necessary to ensure compatibility across all existing features and to avoid introducing unintended side effects.

In addition, having additional spaces does not hinder the use of MATER's issue feature. The feature still fully works as expected, hence rectifying it is less important than the work that has been done already.

Graceful Handling of the Issue The software handles "duplicate issues" gracefully by allowing both as programmatically they are literally not the same when compared binary wise. The application does not crash when the "duplicate issues" are allowed.

Nevertheless, we are willing to put this as NotInScope as it is a possible improvement to MATER. Don't worry as you will still get credit for issues marked NotInScope. Have a good day ahead.

Duplicate status (if any):

--