search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Add command duplication check #2453

Open nus-pe-bot opened 2 days ago

nus-pe-bot commented 2 days ago

image.png

I first added a person based on the example provided in the help message. Then, I added an extra 'e' to name and changed the register number to 11 but it still says person exists.

image.png

Changing the person's address and phone number still gives the duplicate error message. add command only allows this user to be added when email is different. Not sure how duplicate validations are done but I feel that the entry above should be accepted because only using the same email address with all fields already being different can happen when siblings use their parent's email.

[original: nus-cs2103-AY2425S1/pe-interim#1067] [original labels: severity.Medium type.FeatureFlaw]

gohqingkhang commented 18 hours ago

Team's Response

Considering our target users which are Singapore secondary school teachers, we can safely assume that all secondary school students will have their own emails, as are provided by the school with the school email domain, which is common practice in Singapore.

Duplicate status (if any):

--