nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Filter command not allow filtering for people with no tags #2458

Open nus-se-script opened 2 weeks ago

nus-se-script commented 2 weeks ago

Expected Behavior

Since a person can be added or edited with no tags (i.e. edit 1 t/), the user should be able to filter for people with no tags as well.

Current Behavior

Filter does not support the above feature since tag names are validates such that they must not be blank in the filter command.

Steps to Reproduce

Suppose there exist some students in the GUI without tags.

  1. Enter find t/
  2. Observe the terminal error.

Screenshot 2024-11-15 at 5.31.53 PM.png

Context

It's possible that the user has a list of students that have not been allocated to classes and do not have tags to identify their class. Once an allocation is created by the teaching department, the user may want to filter for these students to easily find them and give them their appropriate tags.


[original: nus-cs2103-AY2425S1/pe-interim#3348] [original labels: type.FeatureFlaw severity.Low]

haleemairfan commented 2 weeks ago

Team's Response

I disagree with the suggestion that our find command should allow searching with no tags. The purpose of the find command is to provide teachers with a tool to filter students and parents based on meaningful criteria, such as class, batch, or other relevant tags. Given the context of our target audience, searching with no tags does not align with their needs or the intended functionality of the product. Teachers are unlikely to require a search that returns the entire list, as this would defeat the purpose of filtering and refining data for specific actions. If users need to view the entire list, they can do so by clearing filters or returning to the default state, making a "no tag" search unnecessary. Introducing this feature would add complexity without offering significant value to the product, which is designed to serve the practical needs of our target audience. Therefore, I believe this suggestion should be rejected.

Duplicate status (if any):

--