nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Email field accepts values without a top-level domain #2459

Open nus-pe-bot opened 2 days ago

nus-pe-bot commented 2 days ago

Screenshot 2024-11-15 at 16.19.20.png

As you can see, dino@gmail is accepted as a valid email but it should be dino@gmail.com (missing the .com top-level domain).

This may cause an inconvenience to users, as they may accidentally type in the incorrectly formatted email, and then when they try to copy paste it for use later (like writing an email to that address) they may encounter a problem.


[original: nus-cs2103-AY2425S1/pe-interim#3349] [original labels: type.FeatureFlaw severity.Low]

slidings commented 1 day ago

Team's Response

We see that this may be a problem. However, correct us if we are wrong, this seems to be an underlying assumption that TLD cannot have email services. Eg: user@ai or user@tv could potentially be a valid address if their DNS system is configured with an MX record in the future.

However, we are not technically competent to independent verify or confirm the correctness of that as it seems to be beyond the scope of this course.

Moreover, to ensure that we do not do overzealous input validation, confirming that there is a domain name seems to be sufficient to us.

image.png

Duplicate status (if any):

--