nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Name uniqueness issue #2543

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

System prevents duplicate names but allows similar names with warning

Problem: Creates confusion when 2 customers have identical or nearly identical names - in the real world high likelihood of the same Aaron Tan

Workaround is inefficient and leads to further confusion - e.g Jon 1 and Jon 2 after a while user may forget which jon is which.


[original: nus-cs2103-AY2425S1/pe-interim#3469] [original labels: type.FeatureFlaw severity.Low]

yu-sutong commented 6 days ago

Team's Response

We allow duplicate names with indexing behind because, in real-world settings, it is normal (but rare) to have customers with duplicate names, so we allow uniqueness in name parameter input. We provided a workaround by allowing users to append an index behind the name, or use tags to differentiate between customers with the same name.

Saying the workaround is inefficient because user may forget which is Jon 1 and Jon 2 is invalid because:

  1. People with same name will get mixed up whether or not with our workaround of indexing at the back. In fact, it is even more confusing if we allow exact same name instead of requiring them to put index.
  2. Tags exist for a reason.

We think you are suggesting that we should not allow similar name as well (as it is not clear on what the actual problem in your bug report is). Not allowing similar name is considered overzealous input validation which is wrong as it is possible for people to have similar names.

image.png

Nonetheless, no suggestions have been provided for us regard to dealing with this.

Hence, it is rejected.

Duplicate status (if any):

--