Team's Response

Justification for Duplicates:

The defect lies in the assignProductToSupplier method of AssignProductCommand class. Specifically, the issue arises from adding the product to the supplier's productList before updating the product's supplierName. This inconsistency creates two problematic behaviors:

Duplicate Assigning: A product can be reassigned to the same supplier because the checks for assignment status in checkProductAssignmentStatus method are bypassed due to the outdated supplierName.
Failure to Unassign after calling Assign: When unassigning, the findSupplierWithProduct method considers the product unassigned because the supplierName is not correctly updated in the product.

We attempted to fix:

In the original implementation, the line: updatedProductList.add(product); occurs before updating the supplierName of the product:

private void assignProductToSupplier(Model model, Supplier supplier, Product product) {
        Set<Product> updatedProductList = new HashSet<>(supplier.getProducts());
        updatedProductList.add(product); //problematic line 

        Product updatedProduct = new Product(product.getName(), product.getStockLevel(), product.getTags());
        updatedProduct.setSupplierName(supplier.getName());

        Supplier updatedSupplier = new Supplier(
                supplier.getName(), supplier.getPhone(), supplier.getEmail(),
                supplier.getAddress(), supplier.getTags(), updatedProductList);

        model.setProduct(product, updatedProduct);
        model.setSupplier(supplier, updatedSupplier);
    }

After the fix:

    private void assignProductToSupplier(Model model, Supplier supplier, Product product) {
        Set<Product> updatedProductList = new HashSet<>(supplier.getProducts());

        Product updatedProduct = new Product(product.getName(), product.getStockLevel(), product.getTags());
        updatedProduct.setSupplierName(supplier.getName());

        updatedProductList.add(updatedProduct); //after fix 
        Supplier updatedSupplier = new Supplier(
                supplier.getName(), supplier.getPhone(), supplier.getEmail(),
                supplier.getAddress(), supplier.getTags(), updatedProductList);

        model.setProduct(product, updatedProduct);
        model.setSupplier(supplier, updatedSupplier);
    }

The supplierName is updated before the product is added to the supplier's list. This ensures that checks in checkProductAssignmentStatus and findSupplierWithProduct behave correctly.

The bugs meet the duplicate definition because they are both caused by the same underlying defect in the assignProductToSupplier method. Fixing this defect addresses both issues simultaneously, confirming that they cannot be fixed independently.

Duplicate status (if any):

Duplicate of #3710

nus-cs2103-AY2425S1 / pe-dev-response

Allowed to assign a produce twice #26

Team's Response

Duplicate status (if any):