nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Incomplete error message for invalid email addresses #2815

Open nus-se-script opened 2 weeks ago

nus-se-script commented 2 weeks ago

The error message when adding, editing to an email address that is invalid is incomplete, the error states that:

Emails should be of the format local-part@domain and adhere to the following constraints:
1. The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). The local-part may not start or end with any special characters.
2. This is followed by a '@' and then a domain name. The domain name is made up of domain labels separated by periods.
The domain name must:
    - end with a domain label at least 2 characters long
    - have each domain label start and end with alphanumeric characters
    - have each domain label consist of alphanumeric characters, separated only by hyphens,if any.

However, it does not pick up the issue on having two consecutive _ in the email local-part, to fix this, we can complete the error message by adding 3. Local-part should not have consecutive special characters or updating the User Guide for the domain constraints.

For replication purposes: add n/Jollibee p/92929292 e/jo____llibee@yahoo.com a/NUS U-Town cp/ r/

Screenshot 2024-11-15 170539.png


[original: nus-cs2103-AY2425S1/pe-interim#3846] [original labels: severity.Low type.FunctionalityBug]

vinceg4 commented 2 weeks ago

Team's Response

We agree that we overlooked this issue and did not mention it in the application or the UG. Hence, this is a documentation bug that we have missed out.

Duplicate status (if any):

--