Poor Handling of duplicate detection in tags (or skills)

[nus-pe-bot]

Steps to reproduce: First command: add contact n/Jason p/96536189 e/jason@gmail.com r/Student s/ChatGPT s/CHATGPT Second command: add contact n/Jason p/96536189 e/jason@gmail.com r/Student s/ChatGPT s/ChatGPT

Expected: Warning message for duplicate tags.

Result: Contact added successfully.

Justification: Quoting from CS2103T textbook Bugs related to duplicate detection: Duplicate detection (e.g., detecting if two persons in the address book are the same) is not trivial; often, detecting only the exact string/value matches is not enough. For example, John Doe and john doe are likely to be the same person. Similarly, extra white space (e.g., the user typed an extra space between the two names) is unlikely to mean they are two different persons. Typically, it is best if you can give a warning in such near match cases so that the user can make the final decision. If your app has a duplicate detection feature, make sure its limitations are made clear to the user so that users are not led to believe that duplicates are being detected while many potential duplicate cases go undetected. Otherwise, it can be considered a type.FeatureFlaw.

2 ChatGPT tag ignore one of the tag. However, ChatGPT and CHATGPT do not give warning or ignore the duplicate tags when they are likely to be the same tag and such limitation is not clearly stated in the user guide. Hence, this is exactly the same error (but with tags instead of name) suggested by the textbook hence a feature flaw

Screenshot:

---

_{[original: nus-cs2103-AY2425S1/pe-interim#401] [original labels: type.FeatureFlaw severity.Low]}

[KengHian]

Team's Response

That is a very valid point, thanks for the detailed report!

Duplicate status (if any):

--