search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Duplicate detection in radd is case sensitive #2837

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

The follwong commands

radd 6 a/ 201 BukiT Batok Street 21 #10-163 s/ 01/01/2024 m/3200 and radd 6 a/ 201 Bukit Batok Street 21 #10-163 s/ 01/01/2024 m/3200

both should logically give the same property but are treated as 2 different ones.

Screenshot 2024-11-15 at 5.29.44 PM.png

[original: nus-cs2103-AY2425S1/pe-interim#3875] [original labels: severity.Medium type.FeatureFlaw]

winstonlimjy commented 1 week ago

Team's Response

According to the User Guide, it has already been stated that TrueRental handles duplicate detection based on “rental information is only considered duplicate if and only if the value of ADDRESS parameter matches exactly, including case sensitivity”.

This is to allow the user to have the flexibility in manipulating the addresses.

image.png

However, we believe it can be better, hence we will classify it as NOT-IN-SCOPE. In addition, it is less important than the work done in the current version of the product e.g., it was not related to features delivered in v1.6 or lower priority than the work already done in v1.6.

Duplicate status (if any):

--