nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Duplicate Attendance Event checking #2867

Open nus-se-script opened 2 weeks ago

nus-se-script commented 2 weeks ago

Screenshot 2024-11-15 at 5.06.18 PM.png

Screenshot 2024-11-15 at 5.06.48 PM.png

Command to replicate issue: 1) createattn e/ Lecture 4 1) createattn e/ Lecture 4

Note that there is one additional space between Lecture and 4 in the above 2 events and it was accepted.

It is mentioned that in the UG that Duplicate event names within the same command are not allowed. However, I believe when the user types in a "Lecture 4" or "Lecture 4" leaving an additional space on accident, they will tend to refer to the same event and the user should be warned or the command should not be accepted.

When the TA works under the assumption that no duplicate events exist, he might mark the attendecne for the students seperetely/wrongly under different Events when marking for Lecture 4 which can lead to confusion in the the TA's workflow and incorrect attendance being reported.

Hence, the limitations of the duplicate event checking of the createattedn feature should be made clear the the Users also.

This was also mentioned in the course website:

Screenshot 2024-11-15 at 5.03.47 PM.pngScreenshot 2024-11-15 at 5.03.47 PM


[original: nus-cs2103-AY2425S1/pe-interim#1224] [original labels: type.FeatureFlaw severity.Low]

ishan-agarwal-05 commented 1 week ago

Team's Response

I see that this may result in unexpected behaviour from the viewpoint of the user. This could be fixed in the next iteration

Duplicate status (if any):

--