nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Names only take alphanumeric chars but it is too restrictive and should support other types of characters #2990

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

The application flags names containing / (e.g., "John s/o Tom") as invalid due to it supporting only alphanumeric chars. Other special chars should also be supported because some people's names contain special chars. For example, “Pérez” and "John s/o Tom". This may prevent users from using their actual names and having to use different names to meet the restrictions of the product

Screenshot 2024-11-15 at 4.31.18 PM.png Screenshot 2024-11-15 at 4.31.18 PM


[original: nus-cs2103-AY2425S1/pe-interim#1417] [original labels: severity.Medium type.FeatureFlaw]

darkmoongreatsword commented 1 week ago

Team's Response

image.png

The UG specified that special characters are not supported Parameter Summary of the Clientell User Guide. Furthermore, there exist workarounds to all names with special characters: s/o -> son of, d/o -> daughter of, and apostrophes (glottal stops) or accents are often omitted. Considering users are using this app in English, there exist natural anglicisations of non-english names (In fact, us developers all use anglicised names without the accents in our work).

We deem this support as being of lesser importance for financial consultants than other transaction-related features we focused on implementing. But it's still a reasonable concern to raise, hence our response to also credit the testers partially.

Duplicate status (if any):

--