nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Allowed adding of NRIC starting with T for elderly #3055

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

Steps to reproduce: add i/t0104626d n/jackie Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 c/7 t/wheelchairUser t/livingAlone

Screenshot 2024-11-15 at 4.46.29 PM.png


[original: nus-cs2103-AY2425S1/pe-interim#1576] [original labels: severity.Medium type.FeatureFlaw]

Zenkoh1 commented 1 week ago

Team's Response

We believe that this is low severity, as firstly, this will only occur in very rare situations and will not affect the product, for the following reasons.

There are two cases.

In the case where the user accidentally changes the letter from a S to a T, the user will get the input rejected (correctly) because of the checksum validation done. (eg. S5087089H is valid, but T5087089H is invalid, and will get rejected by ContactMate). Hence, this will never happen.

There is also the case where the user intentionally tries to input a valid NRIC starting with T. In this case, we believe that, at this stage of the project, we should be allowing more flexibility in the inputs of the NRIC. If the user goes out of their way to input an NRIC starting with T (not accidentally), we believe that we should allow it because users might be trying to use the application in a way where we did not even think about. Furthermore, having a valid NRIC starting with T is not harmful in our application, as it is still a valid one that is verifiable by the government, and does not cause any harm in the logic of our application.

If we want to impose further restrictions and less flexibility with NRICs (rejecting NRICs starting with T), this will require further discussion with the target user, which is not in the scope of the current project

Duplicate status (if any):

--