nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Address constraint is incorrect #3104

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

Screenshot 2024-11-15 at 4.28.40 PM.png

Above: User guide says address cannot be blank Below: I managed to add a contact leaving address field blank Screenshot 2024-11-15 at 4.28.34 PM.png


[original: nus-cs2103-AY2425S1/pe-interim#1708] [original labels: severity.Medium type.FunctionalityBug]

appleshill commented 1 week ago

Team's Response

It was already specified in the UG that: User guide says that address field cannot take in \ and all the relevant command formats in the UG (such as for add and edit commands) include obvious spacing, for instance: Screenshot 2024-11-17 at 2.57.56 PM.png

Screenshot 2024-11-17 at 2.57.32 PM.png

\ is rather unlikely to be used in the addresses of individuals or contacts, especially not physical addresses. The only 'addresses' that commonly use \ would be file paths, but the target users of the application are highly unlikely to be storing contacts (of people) with \ in their address.

And on the topic of spacing, Screenshot 2024-11-17 at 3.35.30 PM.png As per the CS2103T website, one can observe that deliberate sabotage is not considered to be a functionality bug. More specifically,

such mistakes should not crash the app, corrupt the data, or make it unusable

The application does not become unusable, the data is still correctly stored as the user input it, and the application does not crash.

Furthermore, the command templates provided should the user click on the GUI buttons already includes the space, as do all mentions of relevant commands in the UG and all example commands provided in the UG, in the help menu of the application, in the manual testing instructions in the DG and the error messages for those commands in the application.

However, we recognise that this can still be used in rare situations and could cause slight inconvenience to those users, and hence would believe it is a low severity bug.

Duplicate status (if any):

--