search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

[Email Format] Single Domain Emails #317

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

Background

Domain portion does not specify the min/max number of domain labels.

Test Case

add n/testemaildomainsingle p/92234567 e/email@security

Expected Behaviour

Reject email adding, single domain emails can cause security issues.

Encountered Behaviour

Successful addition

Remarks, if any

Very low, since unlikely in real life, unless malicious user. Feature flaw since it should be guarded against. Understand if team decides its NotInScope.

[original: nus-cs2103-AY2425S1/pe-interim#447] [original labels: type.FeatureFlaw severity.VeryLow]

KrashKart commented 1 week ago

Team's Response

Thank you! We decided that it is a valid flaw, but we wish to provide the user the flexibility to add emails as they wish. Users are expected to clarify such instances of emails and whilst it should be guarded against, we ultimately give the user a choice on whether to enter such emails under certain contacts.

Duplicate status (if any):

--