nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Didn't specify limitation of client's address #3331

Open nus-se-script opened 2 days ago

nus-se-script commented 2 days ago

image.png Client address is assumed to be able to contain any symbols as no limitations are stated in UG.

test case: client's address contain "vrn/" expected: client is added with address contain "vrn/" actual: error is thrown

image.png


[original: nus-cs2103-AY2425S1/pe-interim#2292] [original labels: severity.Medium type.FunctionalityBug]

Meowloid commented 2 days ago

Team's Response

Reason for change in severity

It is EXTREMELY rare for addresses to contain vrn/ inside the address itself, compared to the overall addresses in Singapore. We were actually unable to find any addresses in Singapore that contained the string "vrn/". It is hence unfair to say that occasional inconvenience is caused as the product works fine on all Singapore addresses, which is the target demographic.

Reason for NotInScope

1) As the application targets primarily the Singapore market, almost all addresses used in Singapore do not contain "vrn/", hence rectifying it is less important than the work that has been done already. 2) Adding additional support for checking if there is "vrn/" or adding other checks is a supposedly 'better' implementation which will take more effort than the current implementation, reducing the effort available to spend on other more important tasks. This is due to the way we need to check for slashes in the string for every command. It is difficult to add the validation whether it is a vrn/ or just a / in a address. Moreover, there are other fields to validate if we validate vrn, like vin, e, p, n, I, make and model. This validation is makes it difficult to add such validation to it as there can be other address with a similar address too. 3) When a user attempts to add such addresses with "vrn/", the software fails gracefully, with an error message informing the user that there should'nt be multiple values specified for the following single-valued field(s): vrn/.

Screenshot 2024-11-18 at 12.02.41 AM.png

Duplicate status (if any):

--