nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Name does not allow hyphens #3392

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

Many people have hyphens in their name, and so it is expected that an application which tracks students should allow hyphens. However, the add command does not allow hyphens

Steps to reproduce

  1. Ensure there is no user called Ben-Lim in the app. If there is you can replace with any user with hyphens
  2. add n/Ben-Lim p/98765432 e/ben@example.com a/John street, block 123, #01-01 f/100
  3. This command will fail to execute. Screenshot is attached below

image.png


[original: nus-cs2103-AY2425S1/pe-interim#2449] [original labels: severity.Medium type.FunctionalityBug]

josh1248 commented 1 week ago

Team's Response

The team agrees that hyphens are a possible occurrence in students' names. However, this would be a feature flaw rather than a functionality bug, as we have stated the validation within the command format (as seen in the screenshot above).

We believe that this warrants a low-severity than medium-severity functionality bug: there is no need for teachers to represent the legal names of their students, character-by-character, in EduLog. Instead, it is for tracking and identification purposes. We hence think that the entry of the student without the hyphen, e.g. Ben Lim, would not significantly diminish the tutor's ability to identify students based on our list. Hence, the inconvenience would be low and rare in the team's opinion.

Duplicate status (if any):

--