nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Adding names doesn't consider names with extra space as duplicates #3409

Open nus-pe-bot opened 2 weeks ago

nus-pe-bot commented 2 weeks ago

command: add n\Betsy Crowe t\friend e\betsycrowe@example.com a\Newgate Prison p\1234567 t\criminal t\CRIMINAL:2 fi\noIncome s\@bestyC command: add n\Betsy Crowe t\friend e\betsycrowe@example.com a\Newgate Prison p\1234567 t\criminal t\CRIMINAL:2 fi\noIncome s\@bestyC

Both of the above contacts can be added to the addressbook, which users might expect to throw an error as they accidentally included an extra space


[original: nus-cs2103-AY2425S1/pe-interim#2491] [original labels: type.FeatureFlaw severity.Low]

appleshill commented 2 weeks ago

Team's Response

With reference to Planned enhancement number 2 in the Developer Guide:

Improve duplicate contact detection: When adding or editing the details of a contact, the duplicate detection feature currently compares NAME only. This could result in an inconvenience to the user should they choose to add multiple contacts with the same NAME. Hence, we plan to extend the current system of detecting duplicates based on NAME to one that detects duplicates by comparing multiple fields, such as but not limited to, NAMEand EMAIL, and only considering a contact to be a duplicate of an existing one if both (or multiple) fields match in value.

As the planned enhancement for duplicate detection does involve checking more than one field to determine if contacts are duplicates, this would no longer be an issue that is faced by the user once that feature has been implemented.

Duplicate status (if any):

--