search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Edit-course command allows duplicated course name #363

Open nus-pe-bot opened 6 days ago

nus-pe-bot commented 6 days ago

Given two existing courses in the program, if I try to edit one of the courses to a course name that already exists in the system, it will allow the system to register it.

Steps to Reproduce:

  1. course-add c/MA1522 n/Linear Algebra
  2. course-add c/MA1520 n/Calculus
  3. course-edit c/MA1522 n/Calculus

Screenshots

Screenshot 2024-11-15 at 4.36.35 PM.pngScreenshot 2024-11-15 at 4.36.35 PM

Reasoning for Severity

While this rarely happens, the system should ensure that the user knows that he/she is editing a course that may potentially clash with another course name, resulting in confusion. A prompt should be provided or stated in the UG about this edge case.

[original: nus-cs2103-AY2425S1/pe-interim#513] [original labels: type.FeatureFlaw severity.Low]

accountexeregister commented 5 days ago

Team's Response

Thanks for raising this. A course is identified by its course code instead of its course name. Different courses (with different course codes) can have the same course name. For instance CS2040S and CS2040C are different courses with different codes but have the same "Data Structures and Algorithms". Nevertheless, we will keep your issue in mind and potentially add a warning in the future.

image.png

Duplicate status (if any):

--