nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Wrong instructions for manual testing (Saving data) #3682

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

image.png As per instructions, I start with an empty book and have this in my address/wedding book:

{
  "persons" : [ {
    "name" : "John Dee",
    "phone" : "98765432",
    "email" : "johnd@example.com",
    "address" : "311, Clementi Ave 2, #02-25",
    "job" : "Caterer",
    "tags" : [ "Tom & Jerry" ]
  } ]
}

And in wedding book:

{
  "weddings" : [ {
    "weddingName" : "Tom & Jerry",
    "venue" : "Orchard Hotel",
    "date" : "12/12/2030",
    "participants" : [ {
      "name" : "John Dee",
      "phone" : "98765432",
      "email" : "johnd@example.com",
      "address" : "311, Clementi Ave 2, #02-25",
      "job" : "Caterer",
      "tags" : [ "Tom & Jerry" ]
    } ]
  } ]
}

Following instructions, i randomly delete the line "tags" : [ "Tom & Jerry" ], leaving the addressbook as

{
  "persons" : [ {
    "name" : "John Dee",
    "phone" : "98765432",
    "email" : "johnd@example.com",
    "address" : "311, Clementi Ave 2, #02-25",
    "job" : "Caterer"
  } ]
}

The advertised Expected behaviour says: "Expected: KnottyPlanners will launch with all previous data wiped and cleared."

Upon relaunching, it FAILED this expectation. In fact, the remaining data is kept and it launches normally.

This failure to give a correct test in the DG is highly problematic. However, because the product can be used, I'm capping this at only medium.

image.png

image.png


[original: nus-cs2103-AY2425S1/pe-interim#3178] [original labels: severity.Medium type.FunctionalityBug]

jonushzw commented 6 days ago

Team's Response

We accept this bug as we agree it is not as advertised in our DG.

However, we lower the severity to Low because it is a rare case to modify the data.

Additionally, the consequences of the bug were unclear and we are unsure to what extent the user will be affected by this modification of data.

Duplicate status (if any):

--