search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Name parameter do not support accented characters #3942

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

Background

Based on UG, the requirements for the NAME parameter must contain only alphabetic characters and whitespace, and Names with only whitespace are not allowed.

Test Case

addStu n/sàm s/A0000000A

Expected Behaviour

Since accented characters such as à and è are also alphabetic characters, the name sàm should be accepted as it contains only alphabetic characters and no whitespaces only.

Encountered Behaviour

Error message stating Names must contain only alphabetic characters and whitespace.

Suggestion

Could state in UG that TrackMate only supports English.

image.png

[original: nus-cs2103-AY2425S1/pe-interim#3854] [original labels: severity.Medium type.FeatureFlaw]

waihongteh commented 1 week ago

Team's Response

This is a tricky issue since our application only supports addition for alphabetic characters in the name.

There are many unique names in the world for example, Elon Musk's sons name is X Æ A-12. By trying to accommodate all sorts of characters, it would be hard as certain computers and operating systems cannot display certain characters. Most importantly, in TrackMate, we are identifying students based on their unique Student ID. As such, the name does not necessarily have to be the full name of the student and is not expected to match the legal name of the person, but rather just something convenient for the user to remember.

However, we do agree that this may be a future implementation that we need to accommodate for all user with different format of name. Given we stated in the User Guide that the name should be in alphabetic character while à considered a vague definition for alphabetic character or special character (online has some resources to explain in both perspective as a normal user we assume A- Z is the alphabetic characters refer here).

As in future implementation, we do mentioned that we will have more implementations to expand the flexibility for legal name. Therefore, we will place it as feature flaw while downgrading to severity.Low as it only appears only in very rare situations which the situation where a person with à legal character happening here.

In this case, we will place a response.NotInScope as we believe fixing it is less important than the work done in the current version of the product.

Duplicate status (if any):

--