nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Early ending of lifeline in DG sequence diagram #404

Open nus-pe-bot opened 2 weeks ago

nus-pe-bot commented 2 weeks ago

image.png

The above screenshot is taken from the sequence diagram illustrating interactions within Logic component, on page 8 of the DG.

The commandResult r has a destroy marker right after its creation, but is then returned to logic as "r" in the return from DeleteCommand to Logic although it had already been destroyed. This may confuse those looking at the DG.

This problem is replicated throughout all sequence diagrams in the DG.


[original: nus-cs2103-AY2425S1/pe-interim#575] [original labels: severity.Low type.DocumentationBug]

SwaminathanViswa commented 2 weeks ago

Team's Response

Thanks for pointing this issue!

Duplicate status (if any):

--