nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

All numeric names can be added through add command #460

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

Problem: All numeric names can be added which should not be allowed

Steps to reproduce:

add n/21354576 p/98765432 e/johnd@example.com a/John street

Screenshot 2024-11-15 164812.png


[original: nus-cs2103-AY2425S1/pe-interim#654] [original labels: severity.Medium type.FeatureFlaw]

jasmiinee commented 1 week ago

Team's Response

Thank you for raising this issue.

However, in our error message, we have stated that names should contain only alphanumeric and spaces, thus the given name 21354567 is a valid name.

image.png

However, we do recognize that it is not common for names to contain numbers and we will consider adding this check in the future.

Duplicate status (if any):

--