search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Chaining find command #597

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

Steps to reproduce:

  1. Enter find david
  2. Enter find alex

After the first command, only entries that have "david" in their name will appear

image.png

However, after typing the second command, I expected it to filter all the "alex" from this list, but instead it finds all "alex" in the full list

image.png

Might hinder a user when he searches for a common username (i.e. "tan"), then out of all those whose surnames are "tan", he wants to search for one whose name contains "alex", but instead he is returned a list of all "alex", even those whose surname is not "tan"

[original: nus-cs2103-AY2425S1/pe-interim#846] [original labels: severity.Medium type.FeatureFlaw]

Sornsornah commented 1 week ago

Team's Response

The behaviour is as expected, where the find command obtains details from the entire list of patients instead from the filtered view of patients. This was stated in the User Guide as follows:

Finds patients whose names contain any of the given keywords.

If there is a need to find both david and/or alex in their name, the user should type find david alex.

We lowered the severity, since we already specified the functionality in the UG. Furthermore, it is unlikely for the user to find twice, given that they should just search in the same command.

Duplicate status (if any):

--