search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Adding command accepts "0000" as birth year #644

Open nus-pe-bot opened 2 weeks ago

nus-pe-bot commented 2 weeks ago

Summary

Allowed to add a birth year of 0000, which should not be allowed

Steps to reproduce

Run this command: add n/John Doe i/S1234567G d/0000-01-01 g/M p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25

Expected

Expect some error about invalid year to be thrown

Observed

Person successfully added

Screenshot 2024-11-15 at 4.20.37 PM.png

Tester Information

Apple M2 Pro 32 GB Java Version: openjdk version "17.0.11" 2024-04-16 LTS OpenJDK Runtime Environment Zulu17.50+19-CA (build 17.0.11+9-LTS) OpenJDK 64-Bit Server VM Zulu17.50+19-CA (build 17.0.11+9-LTS, mixed mode, sharing)

[original: nus-cs2103-AY2425S1/pe-interim#915] [original labels: type.FeatureFlaw severity.Low]

yadobler commented 2 weeks ago

Team's Response

This is a fair point, but unfortunately it is something we were unable to address and have already acknowledged in our UG's "known issues".

image.png

In the future, we plan to improve the validation for dates to align with the Gregorian calendar.

Thank you!

Duplicate status (if any):

--