search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Incorrect name parsing when including names which have "s/o" etc. #826

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

Input: edit 3 n/Maria s/o Hughman Patrick

As seen in the before and after screenshots, Maria s/o Hughman Patrick is shortened to Maria and the rest of the end after s/ is saved as a skill. This invalid parsing could be due to "s/o". The parsing/validation of name should allow for these characters among others e.g. "d/o" as there is a high likelihood these names will be added at some point in time given how this is an app that manages jobs.

Overall, it would be good to allow these names to be added in full by allowing the parser/validation to be more flexible. One could modify the parsing character for skill to be something other than "s/" such as "sk/" or attempt to validate this name while keeping the "s/" identifier.

Before (the command is input)

image.png

After (the command is input)

image.png

After (the command is input) - rest of name is saved as skill

image.png

[original: nus-cs2103-AY2425S1/pe-interim#332] [original labels: severity.Medium type.FunctionalityBug]

LemonDrew commented 1 week ago

Team's Response

No details provided by team.

Duplicate status (if any):

Duplicate of #235