nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Time format could be further explained #964

Open nus-se-script opened 1 day ago

nus-se-script commented 1 day ago

Steps to reproduce

  1. For commands that involve time, add a time that has invalid values for the hours and / or minutes. For example, schedule 2 d/Tue st/08:61 et/09:60.

Expected

The error message should let users know that the minutes entered is out of range, and that it should be within the range of 00 to 59.

Actual

The error message tells the user that "Lesson time should be in 24 hour format (e.g. 16:00)", although the time format is already in a 24-hour format.

How to improve the product

Have a more specific error message to let users know that the hours should be within the range of 00 to 23, while the minutes should be within the range of 00 to 59.

Screenshot

Screenshot 2024-11-15 at 16.32.30.png


[original: nus-cs2103-AY2425S1/pe-interim#1342] [original labels: type.FeatureFlaw severity.Low]

IzN432 commented 3 hours ago

Team's Response

I think it is a reasonable assumption to believe all piano tutors are aware of the 24 hour time format.

Duplicate status (if any):

--