nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Duplicate email not addressed properly #967

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

Reason: In an educational institution, usually the emails are unique to each student to allow for easy identification, not just student id. This duplication would make users confused on which student is which.

Students usually need to provide uniq Example:

add 13132323 n/name2 p/123458999 e/johddd3doe@example.com a/123Fample Street c/Computer Science r/Student

add 13132324 n/name2 p/123458999 e/johddd3doe@example.com a/123Fample Street c/Computer Science r/Student

Expected: an exception message that tells the students should have unique email or phone.


[original: nus-cs2103-AY2425S1/pe-interim#406] [original labels: type.FeatureFlaw severity.Low]

ethan-goh commented 1 week ago

Team's Response

We currently allow duplicates for all other fields, except for student ID as we consider student ID the unique identifier for students. However, under planned enhancement #4 in our developer's guide, we have highlighted our plans to change this in the future. This will allow us to have more robust duplicate detections for other fields, introducing a stronger identification mechanism.

We have thus rejected this bug as it is addressed under our planned enhancements.

Duplicate status (if any):

--