nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Partial matches in findu #987

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

Partial Match is not matching only prefixes

To Reproduce

Type the command findu u/NU while ensuring there are students with this university prefix as well as other students with university's containing NU in their name

Expected behavior

According to the documentation, the findu command is meant to "Finds contacts associated with a specific university from the current displayed list." This contradicts the partial matches supported by the command. Moreover, it is also strange that it does not just search for universities with a certain prefix but checks if the string contains this keyword string. This might come across as a strange implementation as a user would usually associated the search "N" as all the universities with the prefix "N" rather than all universities containing the letter "N"

Severity

High

Reference – cs2103 bug severity levels

Screenshots

image.png

image.png

Desktop

OS: Microsoft Windows Resolution: 2560 X 1440 Version: Windows 11 Home 24H2


[original: nus-cs2103-AY2425S1/pe-interim#1375] [original labels: type.FeatureFlaw severity.High]

verakohh commented 6 days ago

Team's Response

severity.Medium : A flaw that causes occasional inconvenience to some users, but they can continue to use the product. severity.High : A flaw that affects most users and causes major problems for users. i.e., only problems that make the product almost unusable for most users should have this label.

image.png

The user is still able to use this app We also indicated that partial matching works for findu command, but will make it clearer in the future since the user interpreted this in the wrong way

Duplicate status (if any):

--