nus-cs2103 / hubatch

Useful batch CLI scripts for GitHub
GNU General Public License v3.0
1 stars 3 forks source link

Can use recent versions of requirements? #6

Closed okkhoy closed 6 years ago

okkhoy commented 6 years ago

Versions of the modules required are pinned in the requirements. If there is no specific need for these versions, we can simply mention the module name and let python decide the version.

In my case, some packages were downgraded: see install log below

pip install -r requirements.txt
Collecting certifi==2017.7.27.1 (from -r requirements.txt (line 1))
Downloading certifi-2017.7.27.1-py2.py3-none-any.whl (349kB)
    100% |████████████████████████████████| 358kB 2.2MB/s
Requirement already satisfied: chardet==3.0.4 in c:\miniconda3\lib\site-packages (from -r requirements.txt (line 2))
Collecting idna==2.5 (from -r requirements.txt (line 3))
    Downloading idna-2.5-py2.py3-none-any.whl (55kB)
        100% |████████████████████████████████| 61kB ...
Collecting PyGithub==1.35 (from -r requirements.txt (line 4))
    Downloading PyGithub-1.35.tar.gz (2.6MB)
        100% |████████████████████████████████| 2.6MB 3.3MB/s
Collecting PyJWT==1.5.2 (from -r requirements.txt (line 5))
    Downloading PyJWT-1.5.2-py2.py3-none-any.whl
Collecting requests==2.18.3 (from -r requirements.txt (line 6))
    Downloading requests-2.18.3-py2.py3-none-any.whl (88kB)
        100% |████████████████████████████████| 92kB ...
Requirement already satisfied: urllib3==1.22 in c:\miniconda3\lib\site-packages (from -r requirements.txt (line 7))
Building wheels for collected packages: PyGithub
    Running setup.py bdist_wheel for PyGithub ... done
    Stored in directory: C:\Users\workshop\AppData\Local\pip\Cache\wheels\16\ac\6a\9489745d921b8eb7abea30391885fa17ac44caedea3977459b
Successfully built PyGithub
Installing collected packages: certifi, idna, PyJWT, PyGithub, requests
Found existing installation: certifi 2018.1.18
    DEPRECATION: Uninstalling a distutils installed project (certifi) has been deprecated and will be removed in a future version. This
     is due to the fact that uninstalling a distutils project will only partially uninstall the project.
    Uninstalling certifi-2018.1.18:
    Successfully uninstalled certifi-2018.1.18
    Found existing installation: idna 2.6
        Uninstalling idna-2.6:
            Successfully uninstalled idna-2.6
    Found existing installation: requests 2.18.4
        Uninstalling requests-2.18.4:
            Successfully uninstalled requests-2.18.4
Successfully installed PyGithub-1.35 PyJWT-1.5.2 certifi-2017.7.27.1 idna-2.5 requests-2.18.3
You are using pip version 9.0.1, however version 9.0.3 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
Skaty commented 6 years ago

I'm using virtualenvs, so this is not an issue. These dependencies are what is required by PyGithub and requests.

okkhoy commented 6 years ago

I use virtualenv too; was just checking if it was possible to use the latest versions. Nevermind, will close the issue.

damithc commented 6 years ago

I think it's safe to freeze the version. We can't always rely on the backward compatibility of the future versions.