search

nus-cs2113-AY1920S2 / forum

4 stars 0 forks source link

Java CI build Fails only for Windows #92

Open melylopez99 opened 4 years ago

melylopez99 commented 4 years ago

Hello, When I was trying to merge some changes to the JUnit tests, some of the tests failed but just for windows, and they work locally on my windows machine. I have tried multiple times to change things in the code that might affect the CI build for windows, but I still can't figure out why it only fails on windows machines.

https://github.com/AY1920S2-CS2113-T14-2/tp/pull/51

damithc commented 4 years ago

There is always the good ol 'trial-and-error' to narrow down the cause. E.g., keep slimming down the test case until it passes; if it passes eventually, the last thing you removed is the one that is causing the problem. Also, as all other test cases pass except this one, look closer at this test case to find how it differs from other 'almost similar' test cases. Another thing: JUnit does not run tests on a specific order. The order it runs on your computer may be different from the order used by GitHub. If certain tests can influence other tests (tests should be written to be independent of the others), they might fail on some computers. You can compare the order of tests in your computer (use gradle test to that shown on GitHub to see if that is the case).