Contradicting messages when adding card with duplicated names

[nus-pe-bot]

When a card with a duplicated name was created, the messages shown appear contradictory. Perhaps, you can remove the success message as well? Also, perhaps the duplication check can be done earlier once the user has entered the name? That would save the user time from typing another card all over again.

---

_{[original: nus-cs2113-AY1920S2/pe-interim#233]}

[Zhilin-Huang]

Team's Response

The message above says the user has successfully CREATED the flashcard and the message below says the CREATED FLASHCARD is not ADDED. This is not a contradiction as the flashcard is indeed created but not added.

To do duplication check earlier incurs high development cost in terms of time as we need to change the design architecture. If we want it to be done during flashcard creation, then we need to pass in the FlashcardList to FlashcardFactory and make quite some changes to FlashcardFactory which could potentially affect other parts of the application as well. We decided against doing so as this is not a BUG and high development cost is a valid justification for not implementing such feature.

Duplicate status (if any):

--