search

nus-cs2113-AY1920S2 / pe-dev-response

0 stars 0 forks source link

Wrong use of alt frame in DG #564

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Alt frame is used wrongly, as it encompasses only part of a method. The alt frame should only be used to determine whether or not a method is even called. However, in this case it covers half of 2 different methods from TaskList and DeleteCommand. Which means the method is called out of the frame but is affected by the frame which is wrong.

image.png

[original: nus-cs2113-AY1920S2/pe-interim#559]

jichngan commented 4 years ago

Team's Response

Thank you for the insightful response. After much discussion, we understand the mistake in the Sequence Diagram. We will change the activation bar of DeleteCommand and TaskList to suit the Alt frame.

Duplicate status (if any):

--