search

nus-cs2113-AY2021S1 / forum

8 stars 0 forks source link

Request to use NUSMods api and inernet connection issues. #115

Open gy716 opened 3 years ago

gy716 commented 3 years ago

Library

NUSMods API

Purpose

We want to use NUSMods API to check the existence of the module entererd by user and get more information on each module.

License

MIT license https://github.com/nusmodifications/nusmods

URL issues

Is it okay that the app only work if there is internet connection? Because we need to send requests to the API and fetch data from it. We have tried to download the json file in advance and put it into the resource folder. But there are many problems when packaging the jar. So we want to make the app fetch data from api once it is started, where internet connection is necessary.

okkhoy commented 3 years ago

Use of API approved 👍

Is it okay that the app only work if there is internet connection?

See: https://nus-cs2113-ay2021s1.github.io/website/admin/tp-constraints.html#recommendation-testability and decide for yourself. The teaching team will not make this decision for you.

gy716 commented 3 years ago

OK, thank you!