search

nus-cs2113-AY2021S1 / forum

8 stars 0 forks source link

jar file name for GitHub release #124

Open Chongjx opened 4 years ago

Chongjx commented 4 years ago

As per the instruction from the email, we renamed the jar file to the format [team ID][product name].jar but when we release on GitHub, the file name is converted to teamID.productName.jar. Would like to confirm that the file name for GitHub release is to be the same as the LumiNUS one.

image

okkhoy commented 4 years ago

We primarily use the LumiNUS submissions for further evaluations. The JAR on GitHub is a back up + for completeness sake. So it is OK if the GH release is named slightly differently.

Chongjx commented 4 years ago

Noted, thanks!

farice9 commented 4 years ago

Borrowing this thread for a related issue. I noticed the example given in the email was :"[CS2113T-T12-1][Tasks Pro].jar".

Naming it this way might cause issue when running the program in command prompt due to space between "Tasks" and "Pro". Are we more advised to use "_" to replace spaces instead?

Edit: Realized we can use quotation " " to encapsulate the name. But would still appreciate the quick check!

okkhoy commented 4 years ago

Use the one given in the email. Makes our life easier for processing before PE.

farice9 commented 4 years ago

Noted, thanksss! 😄