search

nus-cs2113-AY2021S1 / forum

8 stars 0 forks source link

Sequence diagram bug #130

Open HengFuYuen opened 3 years ago

HengFuYuen commented 3 years ago

Hi prof!

Regarding issue #1110 and the sequence diagram below there was a bug reported stating that there is no return arrow to InfoCommand. I am assuming that the tester means that there is no return arrow from Person class to InfoCommand. However, the method called in Person class setPerson(....) actually returns void and there is no return value. In this case, would it be a valid bug? (perhaps because I need to explicitly show that control is returned to InfoCommand class)

Also, regarding the missing part of the dashed line, would this be a very low severity bug because it is partially missing due to formatting errors or a bug of higher severity?

image

In addition, if there is a misalignment between my method call arrow, my return arrow and the activation bar what severity level would this be?

image

Thank you very much!

okkhoy commented 3 years ago

I can see 3 questions here:

  1. no return arrow from a method returning void -- this is not a bug. UML sequence diagram can have a minimal notation and it is ok to eliminate return arrow from a void method.
  2. blue circle in the first image -- low severity as it is just a formatting error (i can see a small dash between the green and pink boxes.
  3. misalignment of arrow -- medium severity as this is incorrect notation
HengFuYuen commented 3 years ago

Thank you very much prof!