nus-cs2113-AY2021S2 / forum

5 stars 0 forks source link

Do we push the iP weekly homeworks to our public github account? #2

Open Leeyp opened 3 years ago

Leeyp commented 3 years ago

In Week 2, the iP weekly homework instructs us to complete "Level-0: Greet", and commit it. But, I believe that my sourcetree only commits to my local repository, rather than my public Github account for some reason. To do so, I need to push the commit to my account. Is this the correct way?

Does the automatic grading script check our accounts at 00:00 before our tutorial and grades us accordingly?

8kdesign commented 3 years ago

Not sure about the grading thing, but you have to push the changes from sourcetree (after you commit) in order to see it on GitHub.

okkhoy commented 3 years ago

@8kdesign is correct. You need to push the changes to your fork and it should be visible Do note: You need to push the tags also; they are not pushed by default.

Grading: we will check for submissions done before the midnight before your tutorial (even if the script is not run exactly at midnight, we set the cut off time to be the midnight before your tutorial). E.g., if you are in a Wednesday group, we check for submissions done before Tuesday 2359.

Leeyp commented 3 years ago

Sorry, could I ask, what are the tags thing you just mentioned? I was not aware of that feature.

I’m happy to say that I have managed to push my commit to my online GitHub fork for the first implementation :)

okkhoy commented 3 years ago

@Leeyp technically, that comes in week 3 https://nus-cs2113-ay2021s2.github.io/website/schedule/week3/project.html#2-add-increments-commit-tag-push-level-1-level-2-level-3-a-codingstandard Tags: https://nus-cs2113-ay2021s2.github.io/website/schedule/week3/topics.html#tools-git-and-github-tag-naming-commits

I mentioned it as a blanket requirement. not necessary to do this week

JoviYeung92 commented 3 years ago

If i don't push my file from source tree i can also edit it directly from the main file inside github right? How can we know our codes are 100% correct? Are there any checkers?

8kdesign commented 3 years ago

On GitHub, go to the Actions tab. You should see your latest revision getting checked. If it is correct, you should see a green tick once it is done.

okkhoy commented 3 years ago

@JoviYeung92 just to be sure I answer correctly, are you talking about the individual project (iP) or the exercises on GitHub classroom?

For iP, each increment would add something new to the codebase you have developed so far. You need to test it on your machine to see if things are working. During the tutorials, you are required to show a quick demo to your tutors. So things get validated there.

If you are talking about the exercises on GitHub classrooms, there are tests that run via GitHub actions (as mentioned by @8kdesign ) if the test passes, you are doing the right thing. I am preparing a video to demonstrate how to import the exercise to the IDE, do your development and testing; once your tests pass locally, you can push your code, which forms the submissions.

JoviYeung92 commented 3 years ago

@JoviYeung92 just to be sure I answer correctly, are you talking about the individual project (iP) or the exercises on GitHub classroom?

For iP, each increment would add something new to the codebase you have developed so far. You need to test it on your machine to see if things are working. During the tutorials, you are required to show a quick demo to your tutors. So things get validated there.

If you are talking about the exercises on GitHub classrooms, there are tests that run via GitHub actions (as mentioned by @8kdesign ) if the test passes, you are doing the right thing. I am preparing a video to demonstrate how to import the exercise to the IDE, do your development and testing; once your tests pass locally, you can push your code, which forms the submissions.

okay prof, thanks for the information.

jiaqing23 commented 3 years ago

Hi prof @okkhoy , I saw some file called "runtest.sh" in the ip repo, it check that whether my console output is exactly same as the EXPECTED.TXT. But based on my understanding, for the Level 0 task, we can print any message that we want, but the runtest.sh will show "Test result: FAILED". May I know should I follow the text in EXPECTED.TXT?

okkhoy commented 3 years ago

@jiaqing23 it is the other way... When you first clone the IP repository, the expected output is the same as what prints in Duke. So, all is well. But if you changed the main file, then, you need to update the tests (input + expected, what is/how to write a test is not yet covered in the lecture yet) to reflect the changes.

For level 0, you are not expected to update the tests 🙂

PS: If you didn't change anything but still test fails, pl. check the line endings (CR vs CR+LF) that could be the issue

jiaqing23 commented 3 years ago

Thanks @okkhoy for the information :)