nus-cs2113-AY2021S2 / pe-dev-response

0 stars 0 forks source link

Sequence diagram in DG for "add schedule" feature #1062

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


image.png

(pg 4 of DG)


[original: nus-cs2113-AY2021S2/pe-interim#1062] [original labels: severity.High type.DocumentationBug]

lihaoyangML commented 3 years ago

Team's Response

it is more clear to explain this logic in 1 single diagram. As mentioned in textbook, return arrow can be excluded if deemed unimportant smaller alt box is there because there is an important if else condition is within the block For employee controller, the lifeline ends with the activation box itself. For the other 2 classes, there are life lines below the activation boxes but i cut the diagram at the end of the activation boxes because anything after that is out of scope of the explanation for "add schedule"

Hence, the issues you stated are surely not serious issues, thanks

Duplicate status (if any):

--