search

nus-cs2113-AY2021S2 / pe-dev-response

0 stars 0 forks source link

Adding an existing component when weightage is already at 100 will not overwrite old data even if weightage does not cause total to exceed 100 #1173

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Old components' weightages are supposed to be overwritten when a component with an existing name is added. However, when the total weightage already adds up to a hundred, trying to overwrite a component to a lower weightage does not work. The error states that the weightage cannot be negative or exceed a hundred, but overwriting a component to a lower weightage would not result in either.

image.png image.png (30 + 30 + 15 + 15 = 90)

[original: nus-cs2113-AY2021S2/pe-interim#1173] [original labels: severity.Medium type.FunctionalityBug]

liping-eng commented 3 years ago

Team's Response

Thank you for letting us know the bug :)

This may cause you minor inconvenience in situation like this. However, you may edit your component's weightage by setting it as 0 first, before setting it as the lower weightage you chose to change to.

Nonetheless, we recognise this and will make improvement on this in our future implementation.

Duplicate status (if any):

--