search

nus-cs2113-AY2021S2 / pe-dev-response

0 stars 0 forks source link

In valid command parsing #1321

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

When typing the string with only one type of filter, the command excepts more than one parameter without generating en error, even though the command should be invalid. It gives the user who thought the command accepts more than one parameter major inconcinience as the information is not stored.

The string used in the app is shown below:

image.png

However, this is catched in another sequence:

image.png

[original: nus-cs2113-AY2021S2/pe-interim#1321] [original labels: severity.High type.FunctionalityBug]

jadenwjh commented 3 years ago

Team's Response

Consider this: If we were to check the validity of the location, we have to consider all different street names for the entire of Singapore. Hence, we did not include catching for location-type filters, because there is no way for us to keep track of all the road names in SG. Furthermore, what if new roads are added in the future?

Duplicate status (if any):

--