nus-cs2113-AY2122S1 / forum

3 stars 1 forks source link

Record website bugs here #1

Open okkhoy opened 3 years ago

okkhoy commented 3 years ago

Please report bugs you find on the website as comments in this issue. Do note that some links are stale as we have not populated it with the current semester data.

SuibianP commented 3 years ago

Possible typo: githbub

https://github.com/nus-cs2113-AY2122S1/website/blob/40a4a4a780464fcec1599b44a5d24046b11ba9ee/admin/tp-deliverables-ppp.mbdf#L38

https://github.com/nus-cs2113-AY2122S1/website/blob/a1c058767b492826c9186ebd739ab9a1c5ea475c/admin/tp-tasks.mbdf#L353

SuibianP commented 3 years ago

https://github.com/se-edu/se-book/blame/0086f3799378682bf60cf41e1adc5d0669a801bb/cppToJava/gettingStarted/helloWorld/text.md#L29

Might add << endl to C++ code to be exactly equivalent.

SuibianP commented 3 years ago

https://github.com/se-edu/guides/blob/d078d11867de6d64347b32b3d02363c4f3ee921c/conventions/java/rules.mbdf#L432

//Fallthrough is missing whitespace before Fallthrough, which is a violation of Google Java Style Guide 4.6.2.6

a single ASCII space also appears ... On both sides of the double slash (//) that begins an end-of-line comment.

SuibianP commented 3 years ago

The explicit //Fallthrough [sic] comment should be included whenever there is a case statement without a break statement.

Might add that no comment is required for empty case or those that terminates the control flow (e.g. return), as per Google Java Style Guide 4.8.4.2, otherwise the "whenever" is misleading and contradicting.

SuibianP commented 3 years ago

https://nus-cs2113-ay2122s1.github.io/website/schedule/week3/topics.html#key-exercise-filteremails-method

https://github.com/nus-cs2113-AY2122S1/website/blob/9d60f9eb79110930bd365c430883bb5db2e35211/schedule/week3/topics.html#L517

Duplicate filterEmails; fixed in se-edu/se-book@a3f52dccac7d982d9ba24c76bb377d340184a873 but not reflected on the website yet.

richwill28 commented 3 years ago

On Coursemology > Java Coding Exercises > Week 2 > Question 1: Ex1. https://nus-cs2113-ay2122s1.github.io/website/schedule/week2/topics.html#key-exercise-byeworld doesn't redirect to the exercise part correctly. Upon checking, the correct link should be https://nus-cs2113-ay2122s1.github.io/website/schedule/week2/topics.html#exercise-byeworld.

Not sure if this is a mistake from Coursemology or the course website, but I would like to point out that ByeWorld is tagged as [Exercise] instead of [Key Exercise], which is different from the other questions on Coursemology and is probably not what was intended.

SuibianP commented 3 years ago

https://nus-cs2113-ay2122s1.github.io/website/schedule/week4/topics.html#key-exercise-show-priority-color

https://github.com/se-edu/se-book/blob/master/cppToJava/misc/enums/q-showPriorityColor.md

The case indentation fails to conform to the coding standard

Note there is no indentation for case clauses.

okkhoy commented 3 years ago

The case indentation fails to conform to the coding standard

Good catch! let me fix it soon!

richwill28 commented 3 years ago

Just some of the minor whitespace inconsistencies that I found on this page, e.g. public static void swapCoordinates(Point p){. Welp.. couldn't help myself but to list all of them. I'm a bit of a perfectionist 😝

Seem to be violation of this coding standard, more specifically the "White space within a statement" guideline.

richwill28 commented 3 years ago

Oops.. 😂 I've just checked the subsequent weeks as well, and the whitespace inconsistencies seem to be a recurring theme throughout this module...

okkhoy commented 3 years ago

Haha! those code were not written using IDE, so we are still human ;-) It will take a while to get all of it fixed. Thanks for pointing out though.. 👍

richwill28 commented 3 years ago

RATIONALE: Doing so with throw off grammar checkers and ...

Source

The line above should probably be as follows?

RATIONALE: Doing so will throw off grammar checkers and ...

richwill28 commented 3 years ago
Capture (1)

Clicking the link above redirects to https://nus-cs2113-ay2122s1.github.io/website/week7/topics.html, which is a 404 error.

Upon checking, the correct link should probably be on Week 2 which discussed about basic SDLC process models. https://nus-cs2113-ay2122s1.github.io/website/schedule/week2/topics.html#w2-2-sdlc-process-models-basics

okkhoy commented 3 years ago

Thanks, @richwill28 . Fixed