search

nus-cs2113-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Inaccurate input checking for email field for add client #131

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Description: Some invalid email inputs did not have the erroneous warning message.

Steps to reproduce: add -c 3 /n jondd /cn 00000000 /m soamethinga@eg . (invalid email by convention)

Expected: Client added but with warning message shown

Actual:

image.png

[original: nus-cs2113-AY2122S1/pe-interim#141] [original labels: severity.Medium type.FunctionalityBug]

swongts commented 2 years ago

Team's Response

Firstly, the point of parsing for possible erroneous inputs is to warn the user for possible typos and mistakes. However, it is not foolproof and will accept the user's erroneous inputs, only returning a warning message if there are missing symbols/duplicated symbols found commonly in emails. If the user has blantantly input a wrong email, the onus should be on the user who is a data entry specialist and should not make such jarring errors.

Furthermore, the severity should not be labelled as medium as this is a flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only. Emails are only used as a form of contact with the clients.

It is also a feature flaw instead of a functionality bug, as updated.

Duplicate status (if any):

--