nus-cs2113-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Negative exchange rates are allowed #1999

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Screenshot 2021-11-12 at 4.16.43 PM.png

As in the image above, you can see an exchange rate of -1 is allowed by the system and is reflected in the amount spent as well. Maybe the system should disallow users from using values that are illogical like negatives for exchange rates


[original: nus-cs2113-AY2122S1/pe-interim#1970] [original labels: severity.Medium type.FunctionalityBug]

yeezao commented 2 years ago

Team's Response

deliberate design decision - understand that some users may prefer seeing the amount deducted as opposed to a positive number, thus we provide flexibility.

Downgraded to Low - use cases of negative exchange rates will likely be rare.

Duplicate status (if any):

--