nus-cs2113-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Duplicate detection of employees #2206

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

image.png

Refer to employee 4 and 5. Although one may argue that there could be more than 1 David in the company, it is questionable to include 2 Davids with the same phone number, same staff type, with the same salary. TLDR, the minimum is that the name and phone number should be checked as a primary key (identifying key), and two names should be consider similar disregarding case sensitivity.


[original: nus-cs2113-AY2122S1/pe-interim#2163] [original labels: severity.Low type.FunctionalityBug]

kairoskoh commented 2 years ago

Team's Response

The reason for allowing duplicates is to accomodate for situations where the numbers are identical. For example, in a big restaurant, the manager might choose to assign in-house telephones to their respective names. In such situations, multiple employees can have the same number that the manager uses to reach them. In other scenarios, not all employees have mobile phones and unique numbers. Multiple employees can be living under the same roof (shared accomodations) and sharing a single home telephone number. In such cases, they should be allowed to have the same mobile number.

Duplicate status (if any):

--