search

nus-cs2113-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Parsing of Commands (under Implementation) sequence diagram. #2884

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

The lifelines do not end at cross in this sequence diagram. Consider explaining this to the reader if there is a reason behind it.

image.png

[original: nus-cs2113-AY2122S1/pe-interim#2962] [original labels: severity.Medium type.DocumentationBug]

tlyi commented 2 years ago

Team's Response

There is no cross in the diagram mentioned, so we are unsure what the tester is referring to. However, if he is referring to the lifeline of ParserManager not ending, this is because this particular diagram is just a ref frame from the bigger sequence diagram. This is a screenshot from the bigger sequence diagram where this ref frame was called:

image.png

The appropriate ending of lifelines are shown later on in this diagram.

Duplicate status (if any):

--