nus-cs2113-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Cooked command uses even the expired items from far ago #2951

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

enter: cooked r/chicken soup

Automatically used up ingredient that expired very long ago. It is most likely that people will not use expired ingredients, and they will only use un-expired ingredients. Thus it should not used expired items when cooking. This is feature flaw as users are able to add expired items, or keep expired items that they added before (which wasn't expired at that time), but it doesn't mean they will use the very long expired items when they cook.

image.png


[original: nus-cs2113-AY2122S1/pe-interim#2941] [original labels: type.FeatureFlaw severity.High]

bernardboey commented 2 years ago

Team's Response

We reject this issue because this is expected and correct behaviour. As seen in our user guide, expired ingredients will be removed via the cooked command. It is the responsibility of the user to manage expired ingredients.

image.png

Additionally, this issue is rare and is unlikely to affect normal operations of the product. Under normal operations, the user would not have an ingredient from 2 years ago in their repository.

Duplicate status (if any):

--