nus-cs2113-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Add flights command no parameter checking other than the time #616

Open nus-se-bot opened 3 years ago

nus-se-bot commented 3 years ago

Command used: add -f f003 /d aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa /dd 2/5/22 11:00 /r aaaaaaaaaaaaaaaaaaaaaaaaaaaa /rd 15/5/22 23:00 Flight has been added: Flight ID: f003 Departure Flight: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa, 2/5/22 11:00 Return Flight: aaaaaaaaaaaaaaaaaaaaaaaaaaaa, 15/5/22 23:00

There is no limit checks for flight name, and I can input the same flight name for departure and return flights.


[original: nus-cs2113-AY2122S1/pe-interim#637] [original labels: severity.Medium type.FunctionalityBug]

swongts commented 2 years ago

Team's Response

The fields are meant for names of places. It does not make sense to check user's input for these fields as these inputs can be highly diversified. For example, countries can have very long names or users might want to earmark the countries with a description ("aaaaaaaaa"). As a programmer we should not reject these inputs.

Furthermore, the severity should not be labelled as medium as this is a flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.

Duplicate status (if any):

--