search

nus-cs2113-AY2122S2 / pe-dev-response

0 stars 0 forks source link

[FEATURE] fulfill command #598

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Describe the bug
The fulfill command should essentially mark orders as completed. However, we are still able to add orderlines to orders. This is confusing especially when the order is still considered fulfilled.

To Reproduce
Steps to reproduce the behavior:

  1. Type: add ug/ sku/JC1 n/Jasper d/jasper the boy size/small
  2. Type: add g/ sku/JC1 qty/30
  3. Type: add o/ oid/1 r/jasper addr/jasper
  4. Type: fulfill oid/1
  5. Type: add og/ oid/1 sku/JC1 qty/1
  6. Type: fulfill oid/1
  7. See error

Expected behavior
Either the order should become unfulfilled again, or I should not be able to add an orderline to the order.

Screenshots
image.png

Additional context
Testing order fulfill and orderline commands.

[original: nus-cs2113-AY2122S2/pe-interim#534] [original labels: type.FeatureFlaw severity.High]

hjunleon commented 2 years ago

Team's Response

"However, we are still able to add orderlines to orders. This is confusing especially when the order is still considered fulfilled." Technically in the warehouse management system, they can add on orderlines to already fulfilled orders. This is in line with some workflows of warehouses regarding rectifying actions.

Furthermore, intuitively as a user, if you already fulfilled the order, what for bother to add another orderline for generic order fulfilment?

"Either the order should become unfulfilled again, or I should not be able to add an orderline to the order." This is your claim on the expected behaviour, but the current product's behaviour is deliberately designed as such for the aforementioned reasons.

Duplicate status (if any):

--